fix(parquet/file): reject records starting with nonzero repetition levels - #1009
Merged
zeroshade merged 1 commit intoJul 27, 2026
Conversation
zeroshade
approved these changes
Jul 27, 2026
zeroshade
left a comment
zeroshade
left a comment
Member
There was a problem hiding this comment.
Verified: a repeated column must begin each logical record at repetition level 0, but the delimiter accepted a nonzero first repetition level and silently folded it into a record, miscounting boundaries. This cannot false-positive, since a genuine record start always has `curRep == 0`. The new error is threaded through `ReadRecordData` correctly, `errors` is already imported, and the test confirms the invalid level is not consumed. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
A repeated column must start each logical record at repetition level zero. The record reader currently accepts a nonzero first repetition level and silently treats it as part of a record, which can miscount record boundaries.
What changes are included in this PR?
ReadRecordData.Are these changes tested?
Yes. The focused parquet/file test passes.